Various minor meataxe improvements #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
| vec := [], # right-hand sides of system | ||
| failed := false, # flag to indicate inconsistent system | ||
| index := [], # index for row ordering | ||
| ); |
There was a problem hiding this comment.
There is a test in tst/testinstall/meatauto.tst where the arguments are a matrix and a vector.
There was a problem hiding this comment.
I adjusted the test and added some new ones.
There is only one caller fort his which uses the first argument variant. So just remove the superfluous code.
Instead pass the field to the internal helper SMTX_NilpotentBasis
ThomasBreuer
approved these changes
Mar 20, 2025
for MTX.BasisModuleEndomorphisms and MTX.HomogeneousComponents
- don't modify first argument list in-place, make a copy - remove redundant 'flags' matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently @fieker pointed out some small inputs for which the GAP meataxe takes unreasonable amounts of time.
While working on resolving these, I have made numerous small tweaks that also should be added. Since they are mostly local and hopefully uncontroversial I am submitting them hereby in a separate PR.