Add pre-commit hook to avoid large files updates #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why introducing a pre-commit just to by-pass it? Is there a way to automatically by-pass the files that are already in the project such that we don't need to do that by hand in every commit? |
|
The other way around: we introduce a pre-commit to avoid committing large files by accident. If we actually want to do it, we have to consciously bypass the pre-commit stage. |
Ok! I thought we would need to by pass every time because the files are already there. All good here then. |
VictorBarbosaMartins
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why the simtools repo is so large is that we have uploaded at some point accidentally some very large files.
To prevent this, introduced a pre-commit to prevent this:
Set the max value to 500 kB. We have a couple (4-5 files) above this value; in this case I am expected that we consciously bypass the pre-commit hook.