Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve import efficiency for UnitsErrors #909

Merged
merged 1 commit into from
May 3, 2024
Merged

Improve import efficiency for UnitsErrors #909

merged 1 commit into from
May 3, 2024
+2 −2

Conversation

GernotMaier
Copy link
Contributor

The more directory import of from astropy.units import UnitsError instead of from astropy.coordinates.errors import UnitsError improves the import efficiency.

@GernotMaier
change import for UnitsError
Loading
Loading status checks…
3f4d769
@GernotMaier GernotMaier self-assigned this May 2, 2024
@GernotMaier GernotMaier linked an issue May 2, 2024 that may be closed by this pull request
Usage of UnitsError from astropy.coordinates.errors #908
Closed
@GernotMaier GernotMaier marked this pull request as ready for review May 2, 2024 15:01
VictorBarbosaMartins
VictorBarbosaMartins approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@VictorBarbosaMartins VictorBarbosaMartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@VictorBarbosaMartins VictorBarbosaMartins merged commit 3800478 into main May 3, 2024
17 checks passed
@VictorBarbosaMartins VictorBarbosaMartins deleted the astro.coordinates.errors branch May 3, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorBarbosaMartins VictorBarbosaMartins

Assignees

@GernotMaier GernotMaier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of UnitsError from astropy.coordinates.errors
2 participants
@GernotMaier @VictorBarbosaMartins