Units with spaces #866
Merged
Units with spaces #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data_validator.data_dict["type"] = "int64" | ||
| data_validator._prepare_model_parameter() | ||
| assert isinstance(data_validator.data_dict["value"][0], int) | ||
|
|
There was a problem hiding this comment.
Maybe add a test for space separated units? I.e.
data_validator.data_dict["unit"] = "c t"
assert data_validator.data_dict["unit"] == "ct"
There was a problem hiding this comment.
Good point - added a test for this.
But I don't think your assumption is right: in astropy units c t would not resolve to ct but to c*t. So we should to the same thing. But note that this function is just separating the unit string; no other changes are applied.
There was a problem hiding this comment.
Okey true, thanks for adding the further tests. Looks all good now.
tobiaskleiner
approved these changes
Apr 16, 2024
|
Thank you @tobiaskleiner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#865 introduces an issue for combined units including spaces: e.g.,
m sis resolved to['m','s'].This is solved by applying this only when
valueis also of list type. Note that this is still not perfect, but works for the current model parameters.Solves also the missing correct treatment of
inttype for the string-to-list step (where thetypefield is now used to identify float entries).