Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing raytracing unit test #819

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix failing raytracing unit test #819

merged 2 commits into from
Mar 4, 2024

Conversation

GernotMaier
Copy link
Contributor

Unclear why this worked before - setting caplog.at_level(logging.INFO) uses the correct logging level.

Further minor changes:

  • remove a spurious debug print out in a test
  • slightly rearrange the check for KeyError in raytraing:plot (asking for forgiveness..)

@GernotMaier GernotMaier self-assigned this Mar 1, 2024
@GernotMaier GernotMaier marked this pull request as ready for review March 2, 2024 16:24
Copy link
Contributor

@VictorBarbosaMartins VictorBarbosaMartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I also have not figured out why the the level of caplog was changed, as it is supposed to be always come back to its original state when the with statement ends.

@GernotMaier
Copy link
Contributor Author

OK, thanks for the review!!

@GernotMaier GernotMaier merged commit a87e4fe into main Mar 4, 2024
16 checks passed
@GernotMaier GernotMaier deleted the ray-tracing-tests branch March 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants