-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecl-auto): ECL improvements and better custom drawing #161
Open
g0dkar
wants to merge
21
commits into
main
Choose a base branch
from
feat/ecl-auto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgmltn
reviewed
Mar 19, 2025
src/androidMain/kotlin/qrcode/render/extensions/AndroidComposeExtensions.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ecl-auto): ECL improvements and better custom drawing
4.4.0
Changed
VERY_HIGH
toLOW
as to stay closer to what other tools seems to use as a defaultinformationDensity
value now always goes for the least possible value (down from a minimum of 6 set byQRCodeBuilder
)New
InsufficientInformationDensityException
: instead of anIllegalArgumentException
, this new exception is thrown with a more helpful messageuseCustom<Canvas/BufferedImage>()
methods to theQRCodeProcessor
platform-specific classes: This allows users to manually set their own "painting instrument instance".AndroidQRCodeGraphicsFactory
andJvmQRCodeGraphicsFactory
classes. For example:QRCode.ofSquares().withGraphicsFactory(AndroidQRCodeGraphicsFactory(myCustomCanvas, 0, 0))
Removed
forceInformationDensity
was removed. Now the QRCodeBuilder class usesinfoDensity = 0
(default value) as a trigger to compute it automatically since it needs to be>= 1
QRCode()
directly is still 6 as to keep a bit of backwards compatibility 😅Internal
docs/dokka/
folder (that is only for GH Pages)