Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Display LastExecuted in furiko list jobconfigs #115

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

irvinlim
Copy link
Member

Aligns with the output from kubectl.

image

Verified

This commit was signed with the committer’s verified signature.
ErisDS Hannah Wolfe
@irvinlim irvinlim added the area/furiko-cli Related to the command-line interface (CLI) utility. label Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 64.29% // Head: 64.37% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (fcc7a23) compared to base (cc81d8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   64.29%   64.37%   +0.07%     
==========================================
  Files         207      207              
  Lines       11103    11109       +6     
==========================================
+ Hits         7139     7151      +12     
+ Misses       3574     3570       -4     
+ Partials      390      388       -2     
Impacted Files Coverage Δ
pkg/cli/cmd/cmd_list_jobconfig.go 90.21% <100.00%> (+4.17%) ⬆️
pkg/cli/formatter/time.go 82.35% <100.00%> (ø)
pkg/cli/prompt/prompt.go 80.89% <0.00%> (+1.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irvinlim irvinlim merged commit 97f7b3f into main Jan 23, 2023
@irvinlim irvinlim deleted the irvinlim/feat/cli-list-jobconfigs-last-executed branch January 23, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/furiko-cli Related to the command-line interface (CLI) utility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant