Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry 95 #1

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Sentry 95 #1

wants to merge 5 commits into from

Conversation

nxy7
Copy link

@nxy7 nxy7 commented Mar 13, 2025

No description provided.

Comment on lines +101 to 104
argumentsStringList = `(${Array.from({ length: args.length })
.fill(0)
.map((_, index) =>
(sentryParams || []).includes(index) ? args[index] : '_',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
argumentsStringList = `(${Array.from({ length: args.length })
.fill(0)
.map((_, index) =>
(sentryParams || []).includes(index) ? args[index] : '_',
argumentsStringList = `(${Array.from({ length: args.length }, (_, index) =>
(sentryParams || []).includes(index) ? args[index] : '_',

Copy link

@patrykbojczuk patrykbojczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, lgtm

@nxy7
Copy link
Author

nxy7 commented Mar 14, 2025

Other than the one comment, lgtm

Btw I don't intend on merging this until our main BE starts using this commit, because our current DEV/PROD is using develop branch and it won't be compatible with Sentry 9.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants