fix: show variants in subcontracted PO #46711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir-kandoi
commented
Mar 25, 2025
| & (table.is_stock_item == 1) | ||
| & (table.has_variants == 0) | ||
| & ( | ||
| Case() |
There was a problem hiding this comment.
Since variant items do not have their default_bom field set, using Case function I am checking if item is variant or not. If not variant, check if default_bom field is not null. If variant, fetch template item and check that template's default_bom field instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference support ticket 34443
In a subcontracted PO, variant items were not shown. This fixes that.
I have replaced simple filters with a whitelisted server query as I needed to use SQL