Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple Bank Reconciliation Tool issues #46644

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

vishakhdesai
Copy link
Contributor

@vishakhdesai vishakhdesai commented Mar 21, 2025

Issues:

  • Unable to reconcile because of floating point error
  • Unable to properly reconcile Journal Entries.
    • Journal Entry having multiple rows with the same Bank Account are not being able to reconcile against multiple Bank Transactions usning the Bank Reconciliation Tool.
    • Only a partial amount of the Bank Transaction is allocated instead of the full amount, and the Journal Entry is cleared.

image
image

  • On fixing the above issue, another issue occured:

    • On allocating one Bank Transaction with the Journal Entry having multiple rows with same Bank Account, the Reconcile the Bank Transaction shows one of the amount of that Journal Entry -ve as the allocated amount is subtracted from both the rows of the Journal Entry.
    • So instead of showing individual Accounting Entries for the Journal Entry, I have modified the query to show only one row for the Journal Entry.
  • Unable to reconcile one Bank Transaction with other Bank Transaction (maximum recursion depth exceeded)

image

Support ticket: https://support.frappe.io/helpdesk/tickets/33801

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 21, 2025
@vishakhdesai vishakhdesai marked this pull request as ready for review March 21, 2025 13:32
@sagarvora sagarvora changed the title fix: multiple Bank Reconciliation Tool issues fixed fix: multiple Bank Reconciliation Tool issues Mar 24, 2025
@sagarvora sagarvora removed the needs-tests This PR needs automated unit-tests. label Mar 24, 2025
@barredterra barredterra requested a review from marination March 24, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants