fix(payment term): allocate payment amount when payment term is fetched from order #46637
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat102
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
| "paid_amount": schedule.paid_amount, | ||
| } | ||
|
|
||
| if payment_schedule["invoice_portion"]: |
There was a problem hiding this comment.
System is always proportionally splitting. Better to restrict this behavior to only if Automatically Fetch Payment Terms from Order is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
While the payment term is being fetched from the order, the payment amount is not updated based on the invoice value when
allocate_payment_based_on_payment_termsin Payment Terms Template andautomatically_fetch_payment_termsin Accounts Settings are enabled.ref: 34461
Before:
payment-term-allocation-issue.mp4
After:
payment-term-allocation-fix.mp4
Backport need for v15 & v14