Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repost accounting ledger for purchase receipt #46622

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

ljain112
Copy link
Collaborator

@ljain112 ljain112 commented Mar 20, 2025

Issue: Item Valuation Reposting only repost documents where Stock Ledger Entries exist. For provisional accounting for non-stock items in Purchase Receipt, no stock ledger entries are created and if there is any change in expense account, gl entries cannot be modified.

Frappe Support Issue: https://support.frappe.io/app/hd-ticket/34156

no-docs

@ljain112 ljain112 requested a review from ruthra-kumar as a code owner March 20, 2025 07:36
@ljain112 ljain112 marked this pull request as draft March 20, 2025 07:36
@ljain112 ljain112 force-pushed the feat-pr-acc-repost branch from 08cbf14 to b36e356 Compare March 20, 2025 07:56
@ljain112 ljain112 marked this pull request as ready for review March 20, 2025 08:14
@ruthra-kumar ruthra-kumar self-assigned this Mar 25, 2025
@ruthra-kumar ruthra-kumar removed the request for review from rohitwaghchaure March 25, 2025 05:32
@ruthra-kumar
Copy link
Member

@ljain112

We intentionally didn't include Purchase Receipt or Stock related doctypes in Repost Accounting Ledger tool when it was introduced. There is a chance of Account and Stock ledger going out-of-sync, if on repost, document generated different debit-credit amount to the one from the Submit event.

Repost Item Valuation is the better tool for such cases as it handles both the ledgers.

@ljain112
Copy link
Collaborator Author

ljain112 commented Mar 25, 2025

@ljain112

We intentionally didn't include Purchase Receipt or Stock related doctypes in Repost Accounting Ledger tool when it was introduced. There is a chance of Account and Stock ledger going out-of-sync, if on repost, document generated different debit-credit amount to the one from the Submit event.

Repost Item Valuation is the better tool for such cases as it handles both the ledgers.

Repost Item Valuation works only when there are stock ledger entries but in purchase receipts for non-stock items (provisional accounting) there are no stock ledger entries so repost item valuation cannot be used.

And handling this in Repost Item Valuation doesn't make sense.

We can add validation.

@ruthra-kumar
Copy link
Member

Repost Item Valuation works only when there are stock ledger entries but in purchase receipts for non-stock items (provisional accounting) there are no stock ledger entries so repost item valuation cannot be used.

Makes sense.

We can add validation.

No need. We can allow it for all Purchase Receipts.

@ruthra-kumar ruthra-kumar merged commit a8ed8b2 into frappe:develop Mar 25, 2025
13 of 14 checks passed
ruthra-kumar added a commit that referenced this pull request Mar 25, 2025
…-46622

feat: repost accounting ledger for purchase receipt (backport #46622)
ruthra-kumar added a commit that referenced this pull request Mar 25, 2025
…-46622

feat: repost accounting ledger for purchase receipt (backport #46622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants