fix: add fetch from to currency and set default to empty in item price #46620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir-kandoi
commented
Mar 19, 2025
| @@ -150,6 +150,8 @@ | |||
| }, | |||
| { | |||
| "bold": 1, | |||
| "default": " ", | |||
There was a problem hiding this comment.
Note to reviewer: For some reason even when no default was set, the field was being defaulted to INR. I could not find what causes this but this fix works perfectly fine. If there is another way to avoid setting it to just a single space, please let me know.
There was a problem hiding this comment.
This could be from global defaults or some internal function might be setting this
Setting it to blank is incorrect.
Even fetch from doesn't look like a proper fix
There was a problem hiding this comment.
I understand the blank space thing but why fetch from is wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #46618
code is pretty self explanatory