Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Sales Order): make set_missing_values set delivery date in item rows #46518

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 13, 2025

If the Delivery Date is set at the top level of the Sales Order but missing in the item rows, set_missing_values should fix that.

For example, create a Sales Order, set the delivery date, then fetch items from a Quotation. Before, the new item rows didn't get the Delivery Date, now they do.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 13, 2025
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Mar 13, 2025
@ruthra-kumar ruthra-kumar self-assigned this Mar 24, 2025
@ruthra-kumar ruthra-kumar merged commit becb53b into frappe:develop Mar 24, 2025
17 checks passed
@barredterra barredterra deleted the so-set-deliver_date branch March 24, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants