-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(picker): lsp_incoming_calls #1483
base: main
Are you sure you want to change the base?
Conversation
Did you actually test this? There's no finder |
I have, locally only. Not sure if there is a way to test it with TDD though. It's a copy-paste from |
This isn't working for me when I checkout this PR locally. I get error |
There's a caveat though. I'll add it to the original comment as well.
|
Thanks for checking. I might have confused myself somehow. Let me see what I can do address this. I will make this PR a draft. I'll have to research how to "add a finder" though, unless you can nudge me in the right direction :) |
You would have to add the finder in Maybe wait for maintainer's input after he comes back from vacation (see pinned #1482) |
This is a tad bit advanced for my in understanding of lua/neovim async concepts. It's quite simple to implement functionally, but I got stuck with nesting two async calls as one should first do a textDocument/prepareCallHierarchy, and then follow up with callHierarchy/incomingCalls. Anyone care to pick this up? function M.incoming_calls(opts, ctx)
return function (cb)
M.request("textDocument/prepareCallHierarchy", params, function (locationsResult)
innerParams = locationsResult[1]
M.request("callHierarchy/incomingCalls", innerParams, function (result)
result.forEach(item => cb(processItem(item)))
end
end
end
end
``` |
Description
The
lsp_incoming_calls
feature was missingRelated Issue(s)
#463
The originally added mapping overrides the internal VIM gesture: