Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(picker): support something like telescopes __locations_input option for file pickers #496

Closed
1 task done
Miradorn opened this issue Jan 15, 2025 · 4 comments · Fixed by #646
Closed
1 task done

feature(picker): support something like telescopes __locations_input option for file pickers #496

Miradorn opened this issue Jan 15, 2025 · 4 comments · Fixed by #646
Labels
enhancement New feature or request

Comments

@Miradorn
Copy link

Did you check the docs?

  • I have read all the snacks.nvim docs

Is your feature request related to a problem? Please describe.

Hey there and thanks for this great collection of plugin.
I was overjoyed today when I saw that it now includes a picker and tried replacing telescope with it.
It works great for me right now except one very small-ish nitpick: Telescope added an option for file pickers to ignore/forward :line:column information at the end of filenames (see nvim-telescope/telescope.nvim#2791).

I oftentimes have the usecase that i copy a filename e.g. from a ci run including this info and than pasting it into my file picker.
Currently I have to manually remove the info and the file will than be opened not at the correct line.

Describe the solution you'd like

Something similar to how telescope does it, ignore the line/column information for fetching but forward it when opening a file to open it in the proper location.

Describe alternatives you've considered

I guess... stay with telescope? :D

Additional context

No response
@Miradorn Miradorn added the enhancement New feature or request label Jan 15, 2025
@folke
Copy link
Owner

folke commented Jan 15, 2025

I don't get what you mean and neither did I understand what the linked PR / issue was about.
Paste in telescope and press enter on symbol location? What does that mean?

Can you be more specific?

@Miradorn
Copy link
Author

Sorry I'll try to give an example.
Eg I get from a failed Ci run the location of the failed test like "test/stuff_test.exs:123".
If I copy that whole string into the files picker it won't find the file, if I then remove the last part (":123") it will find the file, but when i now press enter it won't open on the (no longer) specified line.

Is that more clear?

@folke
Copy link
Owner

folke commented Jan 15, 2025

Not interested in adding this functionality. This is way too niche.

@folke folke closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@gcollura
Copy link

gcollura commented Jan 15, 2025 •
edited
Loading

+1 on this feature, I myself use it all the time when copying file paths with a line number from an error log. Eg. circleCI error or compilation error or runtime error -> copy "filename.ext:123" > Snacks.picker.files > paste "filename.ext:123".

gcollura added a commit to gcollura/snacks.nvim that referenced this issue Jan 16, 2025
@gcollura
feat(picker): support something like telescopes __locations_input opt…
7f16d5a 
…ion for file pickers folke#496
@gcollura gcollura mentioned this issue Jan 16, 2025
Closed
gcollura added a commit to gcollura/snacks.nvim that referenced this issue Jan 16, 2025
@gcollura
feat(picker): support something like telescopes __locations_input opt…
a6ce00d 
…ion for file pickers folke#496
gcollura added a commit to gcollura/snacks.nvim that referenced this issue Jan 16, 2025
@gcollura
feat(picker): support something like telescopes __locations_input opt…
3201ae8 
…ion for file pickers folke#496
@folke folke reopened this Jan 20, 2025
@folke folke closed this as completed in 5e00b0a Jan 20, 2025
@github-actions github-actions bot mentioned this issue Jan 20, 2025
Merged
folke pushed a commit that referenced this issue Jan 20, 2025
@github-actions
chore(main): release 2.14.0 (#646)
8d820a6 
🤖 I have created a release *beep* *boop*
---


##
[2.14.0](v2.13.0...v2.14.0)
(2025-01-20)


### Features

* **picker.buffer:** add filetype to bufname for buffers without name
([83baea0](83baea0))
* **picker.debug:** debug option to detect garbage collection leaks
([b59f4ff](b59f4ff))
* **picker.matcher:** new `opts.matcher.file_pos` which defaults to
`true` to support patterns like `file:line:col` or `file:line`. Closes
[#517](#517). Closes
[#496](#496). Closes
[#651](#651)
([5e00b0a](5e00b0a))
* **picker:** added `args` option for `files` and `grep`. Closes
[#621](#621)
([781b6f6](781b6f6))
* **picker:** added `undo` picker to navigate the undo tree. Closes
[#638](#638)
([5c45f1c](5c45f1c))
* **picker:** added support for item.resolve that gets called if needed
during list rendering / preview
([b0d3266](b0d3266))
* **terminal:** allow overriding default shell. Closes
[#450](#450)
([3146fd1](3146fd1))
* **terminal:** close terminals on `ExitPre`. Fixes
[#419](#419)
([2abf208](2abf208))


### Bug Fixes

* **dashboard:** added optional filter for recent files
([32cd343](32cd343))
* **debug.run:** schedule only nvim_buf_set_extmark in on_print
([#425](#425))
([81572b5](81572b5))
* **indent:** use correct hl based on indent. Fixes
[#422](#422)
([627af73](627af73))
* **input:** put the cursor right after the default prompt
([#549](#549))
([f904481](f904481))
* **notifier:** added `SnacksNotifierMinimal`. Closes
[#410](#410)
([daa575e](daa575e))
* **notifier:** win:close instead of win:hide
([f29f7a4](f29f7a4))
* **picker.buffers:** add buf number to text
([70106a7](70106a7))
* **picker.buffer:** unselect on delete. Fixes
[#653](#653)
([0ac5605](0ac5605))
* **picker.grep:** correctly insert args from pattern. See
[#601](#601)
([8601a8c](8601a8c))
* **picker.grep:** debug
([f0d51ce](f0d51ce))
* **picker.lsp.symbols:** only include filename for search with
workspace symbols
([eb0e5b7](eb0e5b7))
* **picker.lsp:** backward compat with Neovim 0.95
([3df2408](3df2408))
* **picker.lsp:** lazy resolve item lsp locations. Fixes
[#650](#650)
([d0a0046](d0a0046))
* **picker.preview:** disable relativenumber by default. Closes
[#664](#664)
([384b9a7](384b9a7))
* **picker.preview:** off-by-one for cmd output
([da5556a](da5556a))
* **picker.preview:** reset before notify
([e50f2e3](e50f2e3))
* **picker.undo:** disable number and signcolumn in preview
([40cea79](40cea79))
* **picker.util:** item.resolve for nil item
([2ff21b4](2ff21b4))
* **picker.util:** relax pattern for args
([6b7705c](6b7705c))
* **scope:** parse treesitter injections. Closes
[#430](#430)
([985ada3](985ada3))
* **statusline:** fix status line cache key
([#656](#656))
([af55934](af55934))
* **win:** always close created scratch buffers when win closes
([abd7e61](abd7e61))
* **zen:** properly handle close
([920a9d2](920a9d2))
* **zen:** sync cursor with parent window
([#547](#547))
([ba45c28](ba45c28)),
closes [#539](#539)


### Performance Improvements

* **picker:** fixed some issues with closed pickers not always being
garbage collected
([eebf44a](eebf44a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@folke @gcollura @Miradorn