[Enhance] Update resources folder structure #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. @jamesb93, can I instead of doing this change:
do this change, so if it changes in the future there isn't another fixing pass needed?
|
Yep thats the one I went for! Everything should still work as intended and if you want to change things later then it's not so urgent. |
weefuzzy
pushed a commit
that referenced
this pull request
Feb 21, 2022
* FluidPitch.schelp * FluidPitch.schelp * edited example 8b-mlp-synth-control brought it in line with the max example. the user must put the synth params and 2D slider where they want them, _and then_ click 'add point'. also simplified some of the SC code. * FluidWaveform draws features & gate * new team is credited (#39) * adding guides from UKH and CIRMMT * FluidBufToKr has optional numFrames argument * FluidBufToKr has optional numFrames argument * default for numFrames argument is -1 * FluidBufToKr help file * created FluidFilesPath and a test file * fixed FluidPlotter call createCatColors * allow for passing the file name in as well * one extra slash check! * add section to bottom of nn-->fm for testing with audio files * Revert "one extra slash check!" This reverts commit 3ba5c4b. * add section to bottom of nn->fm to test with audio files * FluidPlotter typo * fix reference to FLUID_PARAMDUMP (#43) * FluidFilesPath helpfile * comments added, ted's TODO added in folder * don't show rms color and allow passing waveformcolor none of this is breaking (i think) * FluidPlotter now allows > 1 identifier to highlight * udpated ted's to do list * updated ted_helpfiles_outline * deleted ted_helpfiles_outline * clean up examples/guides folder * typo * made audio buffer optional for fluid waveform * fluid waveform features are stackable or not * fluid waveform spectrogram scratch paper * colors * fluid waveform spectrogram tests * spectrogram flag is working -- there are some color considerations to make * spectrogram alpha available * read from color-schemes folder * normalizeFeaturesIndependently argument, close method * Nightly Builds and Continuous Integration (#38) * build macos supercollider to begin with * build on nightlies * compile all 3 * sloppy indentation * remove ninja for configs * try all the builds * fix indentation and dependency * try packaging * make fully installation * fix bigobj whinging in github * move bigobj down * remove huge pdb files * remove pdb files * build linux on ubuntu 18.04 LTS * only build on dev branch and ci/nightlies branch * parallelise zipping and correct the name * use max cores on mac * use windows-ly way of zipping files * package things into non-nested zips * download to here * max -> supercollider 🤦 * use ninja and make release builds on windows * sudo apt * and Prs * clone the dev branch of supercollider * clone with https * delete the old release before making a new one * remove extraneous comment * Revert "move bigobj down" This reverts commit 5cd4a35. * Revert "fix bigobj whinging in github" This reverts commit cb172b9. * get core not SC * use proper CMAKE variable for CORE * use DFLUID_PATH not DFLUID_CORE * update tags and remove make * use choco to install ninja * use ninja on windows * update incorrect core link * add working directory * use composite action * correctly point to the composite action * specify toolchain for cmake * use v2 of env flucoma action * use an env variable to call CMAKE * use composite action to build release * remove env * use flucoma actions to do building * use sc not scbuild * moved CSVs * delete scratch paper file * fluid waveform help file * added more color schemes to choose from, also new grey scale * [CI] Actions@v4 (#49) * use v4 of sc actions * dont build on PR * amended the cmake to copy Resources and to capitalise Plugin * omission in the NoveltySlice * WIP towards a 'rasterBuffer' approach, waiting on interface decisions and scaling decisions * melbands weirdness sorted * no more error when audioBuffer is not passed * bump * user specified lin or log scaling * log * agnostic 🪵 * 'imageBuffer' * removed word 'raster' * waveform help file * removed 'teds to do list' from repo * implement startFrame as suggested in #51 * remove extraneous postln * test code for multiple overlays * dummy commit * FluCoMa-ize argument order and defaults, more error checks * 🚧 updating help file examples * still 🚧 * FluidWaveform: featureBuffer to featuresBuffer * Fluid waveform layers (#53) * layers cause race conditions * front method keeps race conditions from happening * allow for image color to be base on alpha * bump * bump * more tests * updated FluidWaveform help file examples * download instructions * made some helpfile examples * change release action * changed first argument to kr to match the default for the restructured text 'schelp_descriptor.schelp' file in the 'flucoma-docs' repo this needs to happen or else SCDocs will throw a warning everytime the user opens this helpfile * begin cleaning up of the examples folder * argument typo in FluidLoudness 'maxwindowSize' --> 'maxWindowSize' * typo: maxWindowSize in FluidLoudness * fix FluidMFCC argument ordering * [Enhance] Update resources folder structure (#57) * copy the whole resources folder from core * make fluidfilespath respect the new structure * FluidChroma and FluidBufChroma help files alignment * FluidMFCC docs repo alignment * FluidLoudness docs repo alignment * FluidCorpusManipulationToolkit Guide * FluidBufNMF removed 'randomSeed' and 'windowType' (docs repo alignment) * converted all ugly paths to FluidFilesPath * fix color-schemes lookup per new folder structure * BufAudioTransport now has A-B based Arguments * Update nightly.yaml Add workflow dispatch for manual launch * moved the sc-only resources to a SC only folder, and change the cmake to copy the right stuff (#61) * Enhance/integrate doc (#68) * Add docs targets to CMake * Add docs targets to nightly workflow * fix doc copying for nightly * try again to fix doc copying for nightly * syntax error in yaml * added the missing 'setLabel' method to FluidLabelSet * a more convenient method call to FluidViewer to get colors * NRT and Data objects ensure params can be set in NRT queue immediately after creation (#71) fixes #70 Co-authored-by: tremblap Co-authored-by: James Bradbury Co-authored-by: Till Co-authored-by: James Bradbury Co-authored-by: Owen Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way in which "Resources" (data, sound) are pulled from the core repository on build. This accomodates:
flucoma/flucoma-core#88
Accompanying is a small update to FluidFilesPath, which will now return the Audio files with the additional level of directory. @tedmoore I'm not sure what this will break if paths are hard coded. I know you are going to pass through the help files and docs anyway at some point, but perhaps this will need a quick go through to update the paths where its easy (such as loading a file using
SomeMassiveLine++"../AudioFiles/Nicol.wavwhich would now beSomeMassiveLine++"../Resources/AudioFiles/Nicol.wav