Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fleet-maintained apps #27134

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

allenhouchins
Copy link
Member

@allenhouchins allenhouchins commented Mar 14, 2025

Testing the new Fleet-maintained apps contributor workflow by adding:

  • Cisco Jabber
  • Discord
  • draw.io
  • Dropbox
  • GitHub Desktop
  • LastPass

@mostlikelee
Copy link
Contributor

@allenhouchins this is fantastic! can you convert this to draft? we're not quite ready (and don't have the test automation) to push this through. i think best path forward is to create a FR and attach this to it, to make sure we get in the frontend work to add the icons and run end-to-end tests.

@allenhouchins allenhouchins marked this pull request as draft March 14, 2025 15:39
@allenhouchins
Copy link
Member Author

@mostlikelee Converted to Draft! I've been chatting with @iansltx on this one. I should be adding another 15 or so titles over the next couple of days to get us closer to parity with Jamf, Kandji, and Automox with the limitation of only using brew casks.

@iansltx
Copy link
Member

iansltx commented Mar 15, 2025

@allenhouchins I just added the FMA outputs here. When you get a chance, add descriptions to the apps.json file, and as you have time please confirm whether the install/uninstall scripts that we auto-generated are handling each package correctly. Feel free to throw a checklist in another comment.

@allenhouchins
Copy link
Member Author

When you get a chance, add descriptions to the apps.json file

@iansltx Does this go in the inputs or outputs file? I didn't see a reference to description in the README.

@iansltx
Copy link
Member

iansltx commented Mar 17, 2025

@allenhouchins Outputs.

@allenhouchins
Copy link
Member Author

allenhouchins commented Mar 17, 2025

Cisco Jabber

  • Install script tested
  • Uninstall script tested
  • Description added

Discord

  • Install script tested
  • Uninstall script tested
  • Description added

draw.io

  • Install script tested
  • Uninstall script tested
  • Description added

Dropbox

  • Install script tested
  • Uninstall script tested
  • Description added

GitHub Desktop

  • Install script tested
  • Uninstall script tested
  • Description added

LastPass

  • Install script tested
  • Uninstall script tested
  • Description added

@allenhouchins
Copy link
Member Author

The uninstall script for Asana leaves a broken menubar app still active that has to be manually quit.
Screenshot 2025-03-16 at 10 04 00 PM

@iansltx
Copy link
Member

iansltx commented Mar 17, 2025

So, probably best to pull Asana from the list until we can handle that uninstall properly, and file a ticket for adding that app.

@allenhouchins
Copy link
Member Author

  • Removed Asana due to the uninstall script not closing out the menubar app.
  • Removed BBEdit since it's available in the App Store.

@allenhouchins
Copy link
Member Author

allenhouchins commented Mar 21, 2025

The uninstaller script for Citrix Workspace does not include any commands to delete /Applications/Citrix Workspace.app. Removing app from list.

@allenhouchins
Copy link
Member Author

@iansltx or @jahzielv what's the process you use or what is the process you expect contributors to use to test out the Install scripts that are generated. I have otherwise tested out the uninstall scripts and updated the apps.json file.

@iansltx
Copy link
Member

iansltx commented Mar 26, 2025

@allenhouchins You can start Fleet server with FLEET_DEV_MAINTAINED_APPS_BASE_URL=https://raw.githubusercontent.com/fleetdm/fleet/refs/heads/allenhouchins-new-fmas/ee/maintained-apps/outputs to point at this branch. Then run the maintained_apps cron to pull the revised apps list (so apps are available). At that point you should be able to add the app and attempt install with the associated script. If that works, we're good.

Yes, the above instructions should be in the FMA readme. FMA guide updates are on me so that'll be part of that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants