PIK-9849 added travelRule support plus fixed description readme #125
Conversation
| district: | ||
| description: Identifies a subdivision within a country subdivision. | ||
| type: string |
There was a problem hiding this comment.
It doesn't make sense. Do we even need second level subdivision? I think we can get away with removing it.
| streetName: | ||
| description: Name of a street or thoroughfare | ||
| type: string | ||
| buildingNumber: | ||
| description: Number that identifies the position of a building on a street | ||
| type: string |
There was a problem hiding this comment.
What if there are other address information, that does not fit inside street name and building number? For example, building name, quarter name, addresses with two streets etc.
That's why having addressLine1, addressLine2 is more inclusive than this one.
There was a problem hiding this comment.
Do you think creating an array of addresses will be better? or just two fields addressLine1, addressLine2?
There was a problem hiding this comment.
I'd go for just two lines
| - SecondParty # The Originator and Beneficiary have a direct relationship. | ||
| - ThirdParty # The transaction involves an intermediary between the Originator and Beneficiary. | ||
|
|
||
| NationalCountryCode: |
There was a problem hiding this comment.
The real full name of this type is "country alpha-2 code". So either call it CountryAlpha2Code or at least CountryCode. "National" is irrelevant here.
| DepositAddressCreationPolicy: | ||
| enum: | ||
| - CanCreate | ||
| - CannotCreate | ||
|
|
||
| RelationshipType: |
There was a problem hiding this comment.
How about TransactionParticipantsRelationship?
| district: | ||
| description: Identifies a subdivision within a country subdivision | ||
| type: string |
No description provided.