Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py): Local Vector Store Plugin #2379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(py): Local Vector Store Plugin #2379

wants to merge 1 commit into from

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Mar 19, 2025

Description:

  • added Dev Local Vector Store plugin
  • added define_indexer api to Genkit Registry

Checklist (if applicable):

@github-actions github-actions bot added docs Improvements or additions to documentation feature New feature or request python Python config labels Mar 19, 2025
@pavelgj pavelgj requested a review from ssbushi March 19, 2025 14:47
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch from 104aa82 to ab1996f Compare March 19, 2025 15:08
ssbushi
ssbushi requested changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@ssbushi ssbushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to include indexer in python.... @pavelgj

@ssbushi
Copy link
Contributor

ssbushi commented Mar 19, 2025

Thanks for working on this... I was half way through the implementation before I saw this PR, maybe I should have been more vigilant in tracking this via an issue..

ssbushi
ssbushi reviewed Mar 19, 2025
View reviewed changes
py/packages/genkit/src/genkit/ai/retriever.py Outdated

# User-provided retriever function that queries the datastore
type RetrieverFn[T] = Callable[[Document, T], RetrieverResponse]


class CommonRetrieverOptionsSchema(BaseModel):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want this anymore? There was some discussion on how useful these common types are.

@pavelgj

@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 3 times, most recently from d6a6a60 to 1882c96 Compare March 21, 2025 14:09
@kirgrim kirgrim requested a review from ssbushi March 21, 2025 14:15
@kirgrim kirgrim mentioned this pull request Mar 21, 2025
Draft
2 tasks
@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch 2 times, most recently from fb3414d to 018c584 Compare March 21, 2025 14:18
Irillit
Irillit reviewed Mar 21, 2025
View reviewed changes
py/packages/genkit/src/genkit/ai/indexer.py Outdated
# Copyright 2025 Google LLC
# SPDX-License-Identifier: Apache-2.0

from typing import Callable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to call it from collections, as it is deprecated in typing.

@kirgrim kirgrim force-pushed the hrymailo/feat/local-vector-store branch from 018c584 to 8a103a9 Compare March 24, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesudeep yesudeep yesudeep approved these changes

@Irillit Irillit Irillit left review comments

@pavelgj pavelgj Awaiting requested review from pavelgj

@timere-nemo timere-nemo Awaiting requested review from timere-nemo

@kamilkorski kamilkorski Awaiting requested review from kamilkorski

@ssbushi ssbushi Awaiting requested review from ssbushi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation feature New feature or request python Python
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirgrim @ssbushi @yesudeep @Irillit