-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redefine collection-level metadata and v0.3.0 #39
base: main
Are you sure you want to change the base?
Conversation
One example for FTW: fiboa/cli#92 |
3b2bd7e
to
3053dcd
Compare
3053dcd
to
8d5b796
Compare
d363307
to
f3db719
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, happy to approve and get this in and evolve as things go. But I do think it's likely now worth explaining a bit more what a 'collection' is conceptually, and explain a bit about merging, and things moving from collection to feature level, and potentially back up. I don't think this needs to be a ton, just enough for people to make sense of how to think about a collection and what properties to put there vs. not
…embers to FeatureCollection
Discussion results:
|
@cholmes Do you want to do your final review? |
Related Issue(s): #13 #40 #26 #34 #35 #36
Notes:
Proposed Changes:
PR Checklist:
or a CHANGELOG entry is not required.