Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine collection-level metadata and v0.3.0 #39

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Aug 30, 2024

Related Issue(s): #13 #40 #26 #34 #35 #36

Notes:

  • CI fails as the fiboa CLI hasn't been updated yet.
  • The geoparquet examples is not up-to-date due to the same reason.
  • Discussion point: GeoJSON encoding - null vs omit property
  • schemas per collection - how to approach this, probably make schemas a special field, not per feature and switch from list to object

Proposed Changes:

  1. see Changelog

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.

@m-mohr
Copy link
Contributor Author

m-mohr commented Oct 24, 2024

One example for FTW: fiboa/cli#92

@m-mohr m-mohr force-pushed the no-collections branch 2 times, most recently from 3b2bd7e to 3053dcd Compare February 4, 2025 22:01
@m-mohr m-mohr added this to the 0.3.0 milestone Mar 10, 2025
This was linked to issues Mar 10, 2025
@m-mohr m-mohr requested review from cholmes and ivorbosloper March 10, 2025 20:25
@m-mohr m-mohr marked this pull request as ready for review March 10, 2025 20:35
@m-mohr m-mohr force-pushed the no-collections branch 2 times, most recently from d363307 to f3db719 Compare March 10, 2025 20:43
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, happy to approve and get this in and evolve as things go. But I do think it's likely now worth explaining a bit more what a 'collection' is conceptually, and explain a bit about merging, and things moving from collection to feature level, and potentially back up. I don't think this needs to be a ton, just enough for people to make sense of how to think about a collection and what properties to put there vs. not

@m-mohr m-mohr linked an issue Mar 12, 2025 that may be closed by this pull request
@m-mohr m-mohr linked an issue Mar 12, 2025 that may be closed by this pull request
@m-mohr m-mohr requested a review from cholmes March 12, 2025 13:17
@m-mohr m-mohr changed the title Redefine collection-level metadata #13 Redefine collection-level metadata and v0.3.0 Mar 12, 2025
@m-mohr
Copy link
Contributor Author

m-mohr commented Mar 19, 2025

Discussion results:

  • Collection id required
  • Dictionary with Schemas per Collection id
  • Merge:
    • People select columns in CLI
    • geometry CRS Needs to be harmonized
    • disallow null in GeoJSON
  • Parquet: don't add best practice to add json file
  • CLI: Separate create stac command
  • FeatureCollection: collection-level data on the top-Level

@m-mohr
Copy link
Contributor Author

m-mohr commented Mar 20, 2025

@cholmes Do you want to do your final review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review
2 participants