Include libadwaita and other dependencies in the app bundle on macOS #271
+133
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrled
force-pushed
the
include-libadwaita-macos-bundle
branch
from
a1d3c7b to
832ce91
Compare
|
Not sure what's up with that Linux failure, I didn't change any of the application code. Maybe it's using some newer version of Rust with more warnings enabled? |
It seems like there are some new clippy lints in the newest version. I will fix that real quick |
|
You can rebase now ;) |
Remove need for recent bash altogether
mrled
force-pushed
the
include-libadwaita-macos-bundle
branch
from
b41aa8e to
f59f91d
Compare
|
There we go, it's passing now |
|
Whats your status on this PR? |
|
Just fixing a minor permissions thing and it's good to go if you want it :)
|
|
Awesome! I will see if I can setup a vm again to at least test it myself once. It's kind of a pain on non-macos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy all the requisite homebrew libraries, including libadwaita, into the macOS bundle. This makes it a standalone app that can be executed directly on any system without installing Homebrew and libadwaita first. Also does away with the requirement that Homebrew is installed to the default location, which is otherwise required because the binary refers to dynamic libraries via their absolute paths.