Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved CLI file structuring #5201

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

ntkathole
Copy link
Contributor

What this PR does / why we need it:

Breaking a large Click CLI file into multiple files improves maintainability and readability.

feast/
│── cli/
│   │── __init__.py
│   │── cli.py        # Entry point for CLI
│   │── group1.py      # Commands for group1
│   │── group2.py      # Commands for group2
|   |── command1.py  # Commands
│   └── cli_utils.py       # Shared Utility functions 
|   └── cli_options.py       # Shared Utility options

@ntkathole ntkathole requested a review from a team as a code owner March 31, 2025 07:42
@ntkathole
Copy link
Contributor Author

@jyejare ^

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

large PR, going to assume you tested this thoroughly. :)

@franciscojavierarceo franciscojavierarceo merged commit 972ed34 into feast-dev:master Apr 1, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants