Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove c++14 directive #2118

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Remove c++14 directive #2118

merged 1 commit into from
Mar 17, 2023

Conversation

jgoeders
Copy link
Contributor

@jgoeders jgoeders commented Mar 9, 2023

This is an alternative to #2117. Instead of compiling dependencies (abseil) with c++14, this PR removes this repo's c++14 directive.

Signed-off-by: Jeff Goeders <[email protected]>
@jgoeders jgoeders changed the title Remove cpp14 directive Remove c++14 directive Mar 9, 2023
Copy link
Contributor

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit 8146f1f into f4pga:master Mar 17, 2023
@jgoeders jgoeders deleted the cpp17 branch March 24, 2023 13:40
LAK132 added a commit to LAK132/prjxray that referenced this pull request Jun 13, 2023
LAK132 added a commit to LAK132/prjxray that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants