Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ws start #9

Merged
merged 7 commits into from
Nov 16, 2018
Merged

Ws start #9

merged 7 commits into from
Nov 16, 2018

Conversation

Krukov
Copy link
Contributor

@Krukov Krukov commented Nov 14, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #9 into master will increase coverage by 1.48%.
The diff coverage is 98.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   97.38%   98.86%   +1.48%     
==========================================
  Files          18       25       +7     
  Lines         344      441      +97     
  Branches        7       15       +8     
==========================================
+ Hits          335      436     +101     
+ Misses          9        4       -5     
- Partials        0        1       +1
Impacted Files Coverage Δ
excars/db.py 85% <ø> (+27.85%) ⬆️
excars/ws/users_map.py 100% <100%> (ø)
excars/app.py 100% <100%> (ø) ⬆️
excars/ws/utils.py 100% <100%> (ø)
excars/redis.py 100% <100%> (ø)
excars/settings/__init__.py 100% <100%> (ø) ⬆️
excars/ws/publish_location.py 100% <100%> (ø)
excars/settings/redis.py 100% <100%> (ø)
excars/ws/tests/test_location_ws.py 100% <100%> (ø)
excars/settings/app.py 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45509ad...6337d58. Read the comment docs.

return f'{USER_PREFIX}{user}'


async def get_all_keys(prefix, redis):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

по идее можно переписать:

return [key async for key in redis.iscan(match=f'{prefix}*')]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

согласен



async def handler(request, ws):
await asyncio.sleep(0.1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем здесь sleep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

попробую без него

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

телегу посмотри)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ща

@Krukov Krukov merged commit 1a79941 into master Nov 16, 2018
@unmade unmade deleted the WS_START branch November 17, 2018 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants