V 190 #54
Merged
V 190 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new ebb_calc.py module Add new functions to calculate LM, LT move properties, with higher precision and handling more cases than their predecessors. deprecate old LM/LT calculation functions
Revise new formulas to all take "clear" as an accumulator argument.
Handle cases for LM, LT, where rate at first step is 0-- and for which we need to check the initial rate at the second step. Add test cases to check that these cases are handled properly.
If rate == 0 at T =1, or rate ==0 at T1, T2. Also fix issue with initial calculation of direction of motion (incorrect value).
Add test cases Remove two invalid tests (invalid initial rate)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functions to compute LM, LT properties; deprecate old versions.
Add T3 calculations.
Expand tests.
New dependency: mpmath