Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add warnings for invalid el triggered consolidations & withdrawals #238

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Feb 9, 2025

adds warnings for probably invalid requests:
image

there are warnings for:

  • consolidation requests to a validator without 0x02 credentials
  • consolidation request from a validator that is younger than the shard committee period (not consolidate-able)
  • withdrawal request for a validator that is younger than the shard committee period (not withdrawable)

fixes #229, but keeps the possibility to submit invalid requests for testing purposes.
cc @remyroy

@pk910
Copy link
Member Author

pk910 commented Feb 9, 2025

#236 should also make the outcome of requests more clear.

@pk910 pk910 merged commit 562267b into master Feb 17, 2025
4 checks passed
@pk910 pk910 deleted the pk910/warnings-for-invalid-operations branch February 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You cannot do a consolidation request from a 0x01 source validator to a different 0x01
2 participants