speedup epoch stats restore from db for old unfinalized epochs #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up the epoch stats restoration from db on dora startup.
Restoring the epoch stats from db can be a time consuming operation when the chain faces long unfinality as currently seen on devnet5:
already takes about 100s (1:40min) to restore and recalculate duties for 687 epochs.
With this PR, the recalculation for attester duties gets skipped for old unfinalized epoch stats.
For old unfinalized epochs, this information is pruned right after restore anyway, so there is no point on computing these duties upfront.
Computing the attester duties is the most time consuming task, as the whole validator set needs to be shuffled for that, so this should speed up the restoration a lot.