Client side rendering for client details #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pk910
added
the
build-docker-image
pk910
commented
Nov 22, 2024
pk910
force-pushed
the
pk910/csr-clients-list
branch
from
4e8824a to
14ce977
Compare
pk910
force-pushed
the
pk910/csr-clients-list
branch
from
14ce977 to
dd806e6
Compare
pk910
changed the title
pk910
changed the title
pk910
removed
the
build-docker-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds client side rendering for the client details in the el & cl client list.
This significantly reduces the page size for instances with a large number of clients (nft devnet).
The clients list itself is still served as html to allow basic page functionality without javascript enabled.
When expanding one of the client rows, the displayed details are rendered client side using knockoutjs.