Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote ip for peer ip #35

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Conversation

Gladear
Copy link
Contributor

@Gladear Gladear commented Mar 18, 2025

Fixes #34.

Use the conn :remote_ip instead of data gotten through Plug.Conn.get_peer_data/1.
This allows to take into account proxies, whilst keeping the remote peer ip as default.

Take the opportunity to replace use Plug.Test by imports.

@Gladear Gladear changed the title use remote ip for peer ip Use remote ip for peer ip Mar 18, 2025
@maennchen maennchen self-assigned this Mar 18, 2025
@maennchen maennchen added the enhancement New feature or request label Mar 18, 2025
@maennchen
Copy link
Member

Thanks @Gladear ❤️

@maennchen maennchen enabled auto-merge (squash) March 18, 2025 15:03
@coveralls
Copy link

coveralls commented Mar 18, 2025

Pull Request Test Coverage Report for Build 548d9f9922a61a27c01cd5474107124fd8784946-PR-35

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.96%

Totals Coverage Status
Change from base Build f1acac5c77ce8d44fd099be86bc1a7de70c22ba8: -0.04%
Covered Lines: 140
Relevant Lines: 149

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 548d9f9922a61a27c01cd5474107124fd8784946-PR-35

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 93.96%

Totals Coverage Status
Change from base Build f1acac5c77ce8d44fd099be86bc1a7de70c22ba8: -0.04%
Covered Lines: 140
Relevant Lines: 149

💛 - Coveralls

@maennchen maennchen merged commit b1d6458 into erlef:main Mar 18, 2025
14 checks passed
@Gladear Gladear deleted the use-remote-ip-for-peer-ip branch March 18, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_peer_ip is based on peer data, not :remote_ip field
3 participants