Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in React Hooks ESLint Plugin when Violating Rules #8

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ironheart122
Copy link
Contributor

Hey, this PR fixes an issue where React Hooks ESlint plugin throws a TypeError: context.getSource is not a function when ESLint finds a violation of React Hook rules. I guess its due to a compatibility issue with ESlint 9.

The issue is sorted using ESLint Compatibility Utilities

Before:

image
image

After:

image

See here for more details:

t3-oss/create-t3-turbo#984
facebook/react#28313 (comment)

…ations using ESLint compat to ensure compatibility with ESLint 9
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 625da69 into epicweb-dev:main Jul 11, 2024
Copy link

🎉 This PR is included in version 1.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ironheart122 ironheart122 deleted the react-hooks branch July 11, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants