Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update usage of typescript reset #20

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

nichtsam
Copy link
Contributor

  1. Filenames in tsconfig.include are resolved relative to the directory containing the tsconfig.json file, therefore including files from packages will not work.
  2. ts-reset/dom already includes ts-reset.

`ts-reset/dom` already includes `ts-reset`
Filenames in `tsconfig.include` are resolved relative to the directory
containing the `tsconfig.json` file, therefore including files from
packages will not work.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer. Thanks for the fix!

@kentcdodds kentcdodds merged commit d9b6e44 into epicweb-dev:main Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

🎉 This PR is included in version 1.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nichtsam nichtsam deleted the pr/typescript-adjustment branch January 4, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants