-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
health_check: add Cached custom health checker #24742
Conversation
Signed-off-by: Jacky Hu <[email protected]>
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Jacky Hu <[email protected]>
Need to fix some format errors |
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Need to figure out:
/wait |
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jacky Hu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Can you provide some more background about this extension in the PR description (also is there a tracking issue)?
// [#extension: envoy.health_checkers.cached] | ||
|
||
// [#next-free-field: 9] | ||
message Cached { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/should the cached server be an upstream cluster?
This should take care of all the connection parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this parameters are for a cache server
The purpose is to avoid query upstream cluster and just use the cache
Yep, we are using a redis cache to avoid excessive/unnecessary health checks to our backend servers. Below is some description about it. I'll update the PR description about it. There is no tracking issue, if needed by you I can create one. |
Need to fix windows build issue by providing alias to static libs as required |
Signed-off-by: Jacky Hu <[email protected]>
Hi, Thanks for the contribution. We can't accept a contribution this large without a tracking issue, small design doc, etc. Also, this extension would need a sponsor to go in the main repo vs. contrib. Please read the contributing guide. I'm going to close this for now until we sort that out. Thanks |
Sorry, I apologize for not providing a issue, I'll provide it today. |
Created issue as required here. |
Signed-off-by: Jacky Hu [email protected]
Commit Message: health_check: add Cached custom health checker
Additional Description: Allow use of cached health check result from an external third party health checker
Risk Level: L
Testing: unit test, manual testing
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]