feat(endo): Add zip #346
Merged
feat(endo): Add zip #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
kris/endo-import
branch
from
883b9a8 to
b79ff16
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
b79ff16 to
a4db807
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
a4db807 to
d7943cf
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
d7943cf to
48c5210
Compare
kriskowal
force-pushed
the
kris/endo-zip
branch
2 times, most recently
from
085d611 to
ff0ff33
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
7006fef to
fe3fc5d
Compare
kriskowal
force-pushed
the
kris/endo-zip
branch
4 times, most recently
from
f32e1ea to
24e8a1f
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
0b20360 to
5f0549a
Compare
kriskowal
force-pushed
the
kris/endo-zip
branch
4 times, most recently
from
f325041 to
a6078ed
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
9d72ff8 to
dcebdfd
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
42a78c6 to
390fe6d
Compare
kriskowal
force-pushed
the
kris/endo-zip
branch
2 times, most recently
from
0926a2d to
e87f75f
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
0017add to
d6aafc2
Compare
kriskowal
force-pushed
the
kris/endo-zip
branch
2 times, most recently
from
7e6eb16 to
46a65c8
Compare
kriskowal
force-pushed
the
kris/endo-import
branch
from
0c20bc4 to
d59f9f3
Compare
warner
approved these changes
Jul 22, 2020
Our current archive format of choice is Zip. Our current implementation of choice is stuk/jszip. Endo's functions that interact with archives assume an Archive interface with read, write, data, and a from-data constructor. To decouple Endo's internals from the specifics of JSZip, this thin adapter presents the JSZip API as this Archive interface.
Indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current archive format of choice is Zip. Our current implementation of choice is stuk/jszip. Endo's functions that interact with archives assume an Archive interface with read, write, data, and a from-data constructor. To decouple Endo's internals from the specifics of JSZip, this thin adapter presents the JSZip API as this Archive interface.