Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding around loading spinner #215418

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Add padding around loading spinner #215418

merged 4 commits into from
Mar 21, 2025

Conversation

ryankeairns
Copy link
Contributor

Summary

Papercut in the add panel flyout where the loading spinner sits flush against the edge of the flyout container.

Before

After

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.
N/A

@ryankeairns ryankeairns added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Mar 20, 2025
@ryankeairns ryankeairns marked this pull request as ready for review March 20, 2025 21:23
@ryankeairns ryankeairns requested a review from a team as a code owner March 20, 2025 21:23
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Mar 20, 2025
Heenawter
Heenawter approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only - changes LGTM. Thanks for tackling this cleanup ✨✨✨ 🚀

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts / Serverless Observability - Deployment-agnostic API integration tests Dataset quality Degraded Fields per DataStream gets the degraded fields per data stream should return the backing index where the ignored field was last seen

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 20.5KB 20.6KB +84.0B

@ryankeairns ryankeairns merged commit fc17693 into main Mar 21, 2025
9 checks passed
@ryankeairns ryankeairns deleted the rk/fix-a-spinner branch March 21, 2025 03:18
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
@ryankeairns @kibanamachine @JoseLuisGJ
Add padding around loading spinner (elastic#215418)
7724554 
## Summary

Papercut in the add panel flyout where the loading spinner sits flush
against the edge of the flyout container.

_Before_
<img width="560"
src="https://github.com/user-attachments/assets/fc56aaf5-c715-4628-b31d-8a013bc06b99"
/>

_After_
<img width="560"
src="https://github.com/user-attachments/assets/2add8305-de39-49b6-b400-4a27102b2a8e"
/>


### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.
N/A

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryankeairns @elasticmachine @Heenawter @kibanamachine