Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet] fix overlay in integrations on mobile #215312

Conversation

paulinashakirova
Copy link
Contributor

@paulinashakirova paulinashakirova commented Mar 20, 2025

Summary

This PR resolves Integrations overlay mobile-view issue.

Before:

Screen.Recording.2025-03-07.at.17.22.05.mov

After:

Screen.Recording.2025-03-20.at.12.00.31.mov

@paulinashakirova paulinashakirova requested a review from a team as a code owner March 20, 2025 11:01
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@paulinashakirova paulinashakirova self-assigned this Mar 20, 2025
@paulinashakirova paulinashakirova added release_note:fix backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Mar 20, 2025
@nchaulet nchaulet self-requested a review March 20, 2025 12:20
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked as expected 🚀

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +96.0B

cc @paulinashakirova

@paulinashakirova paulinashakirova merged commit b39b8c4 into elastic:main Mar 20, 2025
16 checks passed
@paulinashakirova paulinashakirova deleted the integrations-overlay-mobile-view branch March 20, 2025 18:50
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13977089988

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 215312

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 21, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 215312 locally

@paulinashakirova
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

paulinashakirova added a commit to paulinashakirova/kibana that referenced this pull request Mar 23, 2025
## Summary

This PR resolves [Integrations overlay
mobile-view](elastic#214146) issue.

(cherry picked from commit b39b8c4)

# Conflicts:
#	x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/components/package_list_grid/index.tsx
paulinashakirova added a commit that referenced this pull request Mar 24, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[fleet] fix overlay in integrations on mobile
(#215312)](#215312)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-20T18:50:12Z","message":"[fleet]
fix overlay in integrations on mobile (#215312)\n\n## Summary\n\nThis PR
resolves [Integrations
overlay\nmobile-view](#214146)
issue.","sha":"b39b8c4591609380719cf4f7ae6f2224b9a9c9fa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport
missing","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[fleet]
fix overlay in integrations on
mobile","number":215312,"url":"https://github.com/elastic/kibana/pull/215312","mergeCommit":{"message":"[fleet]
fix overlay in integrations on mobile (#215312)\n\n## Summary\n\nThis PR
resolves [Integrations
overlay\nmobile-view](#214146)
issue.","sha":"b39b8c4591609380719cf4f7ae6f2224b9a9c9fa"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215312","number":215312,"mergeCommit":{"message":"[fleet]
fix overlay in integrations on mobile (#215312)\n\n## Summary\n\nThis PR
resolves [Integrations
overlay\nmobile-view](#214146)
issue.","sha":"b39b8c4591609380719cf4f7ae6f2224b9a9c9fa"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v9.0.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 24, 2025
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
## Summary

This PR resolves [Integrations overlay
mobile-view](elastic#214146) issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrations overlay mobile-view
4 participants