add scaled field files for the early science magnet settings #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused, how these are supposed to be used if they are not included from any configurations? |
|
They would have to be included "by hand" in a configuration. If we want to automate it, we will need to adjust the YAML file which is used to generate the "craterlake_[EBEAM}x[PBEAM}.xml" files. |
|
I think that should be done. |
|
Okay, cool - I just pushed a new commit with those files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds the necessary XML files to steer the beam correctly for 6 of the 7 early science settings. I have not added the 10x100 GeV Au setting for right now since we are not even producing files for it.
[remedied with new commit] One thing that has NOT been added in the configuration YAML files for craterlake. This is because those YAML files don't have a field for the ion species.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, it just adds the magnet settings to steer the ion beams for early science.
Does this PR change default behavior?
No, just adds additional functionality for ions.