-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): run_material_map_validation.sh use v33.1.0 scripts #779
Conversation
Succeeds now and looks fine in artifacts at https://github.com/eic/epic/actions/runs/10946548910/job/30393563281?pr=779. The FPE does not seem to make the entire workflow invalid. |
@veprbl The geoviewers are failing since we don't have a build_detector phase. I'm adapting the geoviewer jobs to use /opt/detectors/epic-main, see https://eicweb.phy.anl.gov/EIC/benchmarks/geoviewer/-/merge_requests/4. This will require that we trigger the geoviewer job from the container build, and not directly from here. Or did you have a different idea for this? |
Force merged 🔨 |
Yes. That would be in line with our current best approaches. My first reaction was to revert https://eicweb.phy.anl.gov/EIC/benchmarks/common_bench/-/merge_requests/91. In the long term, geoviewer should be just another detector benchmark, so it would do good for us to exercise it to run via a container build. |
I think all we'd lose in the short term is the links to geo viewers on GitHub since we don't pass the GitHub CI tokens to post external statuses. |
Briefly, what does this PR introduce?
This PR updates the version of the scripts used for material map validation to the version of ACTS that is used in the environment.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.