Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine pulses in the same CellID #1762

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Combine pulses in the same CellID #1762

wants to merge 44 commits into from

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Mar 19, 2025

Briefly, what does this PR introduce?

Follow on from #1758

Allows a linear sum of pulses across time for each cell within a certain period of each other.

Example plots come from combining the first 5 hits in the whole of the Low-Q2 tagger into one channel.

Combined pulses

PulseCombined

Pulses which were combined into one

Pulses

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Adds TaggerTrackerCombinedPulses and TaggerTrackerCombinedPulsesWithNoise to the output.

simonge and others added 30 commits March 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant