Fix bug in intent and initialisation of spectral arrays #243
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhatfield
changed the title
marsdeno
reviewed
Mar 31, 2025
| @@ -88,8 +88,8 @@ SUBROUTINE PRFI1BAD(KM,PIA,PSPEC,KFIELDS,KFLDPTR) | |||
| IFLD = KFLDPTR(JFLD) | |||
| DO J=1,ILCM | |||
| INM = IOFF+(ILCM-J)*2 | |||
| PSPEC(IFLD,INM ) = PSPEC(IFLD,INM ) + PIA(J+2,IR) | |||
There was a problem hiding this comment.
I would want to be very sure that we're not relying on the += anywhere before changing the code like this. If we are relying on values already in PSPEC in any call to PRFI1BAD, the right fix for this issue might be to zero the 5 arrays (spvor, spdiv, spscalar, spsc2, spsc3b) at the beginning of LTINV_CTLAD ?
| REAL(KIND=JPRB) ,OPTIONAL,INTENT(INOUT) :: PSPSC2(:,:) | ||
| REAL(KIND=JPRB) ,OPTIONAL,INTENT(INOUT) :: PSPSC3A(:,:,:) | ||
| REAL(KIND=JPRB) ,OPTIONAL,INTENT(INOUT) :: PSPSC3B(:,:,:) | ||
| REAL(KIND=JPRB) ,OPTIONAL,INTENT(OUT) :: PSPVOR(:,:) |
There was a problem hiding this comment.
LTINVAD is being called inside a loop in ltinv_ctlad, so intent(out) on these arguments is not conceptually correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's track the
PSParrays through the inverse transform adjoint:INV_TRANSAD:INTENT(OUT) :: PSP...INV_TRANS_CTLAD:INTENT(OUT) :: PSP...LTINV_CTLAD:INTENT(OUT) :: PSP...LTINV_AD:INTENT(INOUT) :: PSP...The intent changes from
OUTtoINOUT!!!On top of that the packing logic in
PRFI1BADis+=even though the spectral arrays are uninitialised. This was triggering compiler-specific failing of theINV_TRANS/ADtest in this PR.This PR resolves the inconsistency in intents and prevents uninitialised array bugs from appearing in
PRFI1BADby changing the packing logic to just=.