Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise with pafv_CY49R1.0_fixers.IFS-3572 #235

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Synchronise with pafv_CY49R1.0_fixers.IFS-3572 #235

wants to merge 10 commits into from
+1,396 −17

Conversation

samhatfield
Copy link
Collaborator

This PR contains changes required to synchronise with Filip Vana's ifs-source branch pafv_CY49R1.0_fixers.IFS-3572.

@samhatfield samhatfield force-pushed the IFS-3572_sync branch 2 times, most recently from 1e53cb0 to fada1c5 Compare March 14, 2025 14:57
@samhatfield samhatfield marked this pull request as ready for review March 14, 2025 16:47
@samhatfield samhatfield added enhancement New feature or request API change labels Mar 14, 2025
@wdeconinck
Copy link
Collaborator

The GPU code-path will have missing symbols.

@wdeconinck
Copy link
Collaborator

Could this new development also be accompanied with a unit-test?

@samhatfield
Copy link
Collaborator Author

The GPU code-path will have missing symbols.

Why is that?

@samhatfield
Copy link
Collaborator Author

Could this new development also be accompanied with a unit-test?

It could, but we don't have unit tests for other external routines (apart from SETUP_TRANS0) either. Any reason why this one needs one?

@wdeconinck
Copy link
Collaborator

The GPU code-path will have missing symbols.

Why is that?

Never mind, I see the GPU place-holders. I missed them last review. :)

@samhatfield samhatfield changed the title Syncronise with pafv_CY49R1.0_fixers.IFS-3572 Synchronise with pafv_CY49R1.0_fixers.IFS-3572 Mar 19, 2025
@samhatfield samhatfield added this to the Version 1.6.0 milestone Mar 19, 2025
@samhatfield samhatfield force-pushed the IFS-3572_sync branch 2 times, most recently from 6fad5d3 to c54d5d6 Compare March 20, 2025 15:54
@samhatfield
Copy link
Collaborator Author

macOS tests are failing due to:

  <TL(X1),Y2>  =          0.962041244086947E-05
  <X1,AD(Y2)> =          0.962041244087702E-05
  Relative error = .784660498947183E-12
   ABORT_TRANS CALLED
   TEST_GPNORM_TRANS_ADJOINT: test failed
  *******************************
  TEST_GPNORM_TRANS_ADJOINT: test failed
  Relative error greater than 2000 * machine epsilon
   0.78E-12 >  0.44E-12
  *******************************
   ABORT!    1 TEST_GPNORM_TRANS_ADJOINT: test failed

So we will need to increase the tolerance again, possibly to 4000 * machine epsilon.

@samhatfield
Copy link
Collaborator Author

All tests now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API change enhancement New feature or request
Projects
None yet
Milestone
Version 1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samhatfield @wdeconinck