Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Update pnpm to latest v10.4.1 and fix compatibility with Netlify #2422

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Feb 24, 2025

- Update to lockfile version 9 without updating dependencies
- Add npm corepack configuration for pnpm 9.15.6 (latest 9.x)
- Set lower bound for pnpm tp 9.15.4 (currently used by Netlify)
- Update dev container
- Update README, dev container and corepack reference
- No lockfile changes are necessary relative to pnpm 9
Remove pnpm version from  CI workflows to use the version specified in the root package.json's `packageManager` property.
This property is set by npm corepack.

Also update the pnpm setup actions and pin them to a fixed commit hash.
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c23cfd9
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67bc9c577299b40008668c9e
😎 Deploy Preview https://deploy-preview-2422--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler
Copy link
Contributor Author

Netflify seems to adhere to the packagemanger configured by corepack as can be seen in this deploy log: https://app.netlify.com/sites/jsonforms-examples/deploys/67bc9aa8ca12af0008449438.
Thus, we can increase the lower version to match the tested one.

@coveralls
Copy link

coveralls commented Feb 24, 2025

Coverage Status

coverage: 82.517%. remained the same
when pulling c23cfd9 on lk/update-pnpm-version
into 64fba38 on master.

@lucas-koehler lucas-koehler requested a review from sdirix February 24, 2025 16:25
@lucas-koehler lucas-koehler added this to the 3.6 milestone Feb 24, 2025
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@lucas-koehler lucas-koehler merged commit daa1836 into master Feb 25, 2025
11 checks passed
@lucas-koehler lucas-koehler deleted the lk/update-pnpm-version branch February 25, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants