Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deployment repository #772

Merged
merged 1 commit into from
Jul 19, 2024
Merged

feat: Add deployment repository #772

merged 1 commit into from
Jul 19, 2024

Conversation

GliczDev
Copy link
Contributor

What does this PR do?

Adds deployment repository


The only problem is that I'm not sure how should I configure Jenkinsfile for deployment
https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28
should I add deploy goal here?

@sebthom
Copy link
Member

sebthom commented Jul 19, 2024

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

@sebthom
Copy link
Member

sebthom commented Jul 19, 2024

What does this PR do?

Adds deployment repository

The only problem is that I'm not sure how should I configure Jenkinsfile for deployment

https://github.com/eclipse/tm4e/blob/d77316439d39a8254a455f207dbb4c582968a9e2/Jenkinsfile#L28

should I add deploy goal here?

no, this job is only for snapshot builds.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

@GliczDev
Copy link
Contributor Author

Thanks for your PR. For being able to process this PR, you need to sign the Eclipse Contributor Agreement (ECA)

done

deploys to maven central.

wdym maven central? my PR adds repo.eclipse.org tm4e deployment repository.

Release builds are done by https://ci.eclipse.org/tm4e/job/promote-snapshot-to-release/ but I don't know what/how to change it so it deploys to maven central.

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

@sebthom
Copy link
Member

sebthom commented Jul 19, 2024

I think adding mvn deploy should be enough, but I don't use maven so I'm not sure.

adding deploy here will still only publish to the snapshot repo as this Jenkins job is not used to create releases.
also it would unnecessarily publish all modules to the snapshot repo, not only the core module.
I am going to prepare a separate PR that only publishes the core module.

@sebthom sebthom merged commit 7d8690e into eclipse-tm4e:main Jul 19, 2024
16 checks passed
@sebthom
Copy link
Member

sebthom commented Jul 19, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants