Propagate known key info to ConcurrentHashMap.get #21439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConcurrentHashMap.get is similar in nature to HashMap.get operations, and we can benefit from compile-time folding of various queries such as Object.hashCode() if the object being passed as arg is known and fixed. For that to be possible, we need to ensure that the caller method of ConcurrentHashMap.get() undergoes peeking IL-gen so that the object information can be passed down and used. Signed-off-by: Nazim Bhuiyan <[email protected]>
|
@vijaysun-omr requesting review |
|
jenkins test sanity all jdk21 |
vijaysun-omr
approved these changes
Mar 24, 2025
|
I think you felt that |
|
All the tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConcurrentHashMap.get is similar in nature to HashMap.get operations, and we can benefit from compile-time folding of various queries such as Object.hashCode() if the object being passed as arg is known and fixed. For that to be possible, we need to ensure that the caller method of ConcurrentHashMap.get() undergoes peeking IL-gen so that the object information can be passed down and used.
In Draft state until further testing is done.