Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to listen to selection changes in autocompleter #420

Merged

Conversation

haydar-metin
Copy link
Contributor

What it does

Fixes eclipse-glsp/glsp#1495
Triggers on change event for autocompleter

How to test

Open the search palette and go through the list

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@haydar-metin haydar-metin self-assigned this Mar 26, 2025
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thank you very much, Haydar!

I see that the CI fails though with this test case: The edge edit tool > should allow reconnecting edges in the graph. It seems unrelated but can you confirm?

@haydar-metin
Copy link
Contributor Author

Yes, the failure has nothing to do with this PR.

@haydar-metin haydar-metin force-pushed the fix-autocompleter-on-change branch from a8eb762 to 66aaf6b Compare March 27, 2025 08:06
@haydar-metin haydar-metin force-pushed the fix-autocompleter-on-change branch from 66aaf6b to 0eb8653 Compare March 27, 2025 08:07
@tortmayr tortmayr merged commit bf7d28e into eclipse-glsp:master Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants