Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set totalEntitySizeLimit to larger value #25314

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

arjantijms
Copy link
Contributor

@arjantijms arjantijms commented Jan 7, 2025

It was decreased in JDK 24 and causes issues

Changeset in JDK: openjdk/jdk@28c8729#diff-d5cb9e1e659383432d1b1a3a7ee0864815fbb2fcdf778a0e5ed52f2835048b5dL109

It was decreased in JDK 24 and causes issues
@arjantijms arjantijms added this to the 8.0.0 milestone Jan 7, 2025
@pzygielo
Copy link
Contributor

pzygielo commented Jan 7, 2025

@OndroMih
Copy link
Contributor

OndroMih commented Jan 7, 2025

I would rather implement this in JvmOptions (call addSysProp("-Djdk.xml.totalEntitySizeLimit=50000000"); before processing options), so that the default value is used also when upgrading from an older domain, which doesn't contain the JVM option. And we should document it as the default value somewhere in GlassFish docs.

We can also keep it in the default domain.xml, so that it's easier to see the default value in the stock GlassFish domain.

If this is added only to domain.xml, it will apply only for new installations and not for upgraded installations.

@arjantijms arjantijms merged commit 7b6af85 into eclipse-ee4j:8.0 Jan 7, 2025
2 checks passed
@arjantijms arjantijms deleted the totalEntitySizeLimit branch January 7, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants