Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate WaSP 4.0.0 #25299

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Integrate WaSP 4.0.0 #25299

merged 1 commit into from
Dec 26, 2024

Conversation

arjantijms
Copy link
Contributor

@arjantijms arjantijms commented Dec 26, 2024

No changes vs M2, simply promoted M2 to final.

Updated old Jakarta Tags TCK, but has to be replaced by new TCK (maven / junit based) to pass everything.

@arjantijms arjantijms added this to the 8.0.0 milestone Dec 26, 2024
@arjantijms arjantijms self-assigned this Dec 26, 2024
@pzygielo
Copy link
Contributor

https://github.com/eclipse-ee4j/wasp/releases/tag/4.0.0 seems to be placed at 7905de0 (current master there), which is at 4.0.0-SNAPSHOT. I can't see release branch in wasp repository, how this 4.0.0 release will be merged there?

@pzygielo
Copy link
Contributor

Regarding WASP 4.0.0 branch, which is strange:

+ git commit -m 'Prepare next development cycle for 4.0.1-SNAPSHOT'
[4.0.0 e000135] Prepare next development cycle for 4.0.1-SNAPSHOT
 1 file changed, 1 insertion(+), 1 deletion(-)
++ git status
+ GIT_STATUS='On branch 4.0.0
nothing to commit, working tree clean'
+ echo On branch 4.0.0 nothing to commit, working tree clean
On branch 4.0.0 nothing to commit, working tree clean
+ '[' false = true ']' 
+ echo '-[ Push branch and tag to GitHub ]----------------------------------------------'
-[ Push branch and tag to GitHub ]----------------------------------------------
+ ls -altrh

Seems it was not pushed actually.

@arjantijms
Copy link
Contributor Author

'[' false = true ']

That line needs to go from the job and the tag should always be pushed

@arjantijms arjantijms merged commit 572060f into eclipse-ee4j:8.0 Dec 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants