SpotBugs based cleanup in nucleus-admin and surroundings #25149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Reported by SpotBugs as impossible cast - However it seems this method is unused now. Signed-off-by: David Matějček <[email protected]>
- Added curly braces - Removed unused StartupContext field. - Removed redundant field initialization. Signed-off-by: David Matějček <[email protected]>
…imeout - Default is 3 seconds, but tests can be fast enough to make it in 1 second. Signed-off-by: David Matějček <[email protected]>
…ericSniffer Signed-off-by: David Matějček <[email protected]>
- Two "logging" classes with bugs reported by SpotBugs - Two empty packages Signed-off-by: David Matějček <[email protected]>
- Created method getCharset in the Utility class with code extracted from two convert* methods and then refactored. The charset parameter of those methods was then changed from String to Charset, so some callers have to resolve the string charset before the call, some used explicit Charset value. - FileRealmHelper should not depend on default charset, because it can change. Using UTF-8 instead. - TextLoginDialog - deleted unused password attribute - Logger moved to its only usage - Fixed formatting, usage of enhanced loop - Fixed some javadocs Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Removed printing stacktrace to logs, lets logging do that. - Use charset from response to parse response, not from own operating system. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Removed printing stacktrace to logs, lets logging do that. - Use charset from response to parse response, not from own operating system. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
… charset Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- The class wrote the file with system charset but declared UTF8 in xml - Constructor called instance methods, now uses just static methods - The instanceStates property was not used - Added missing curly braces Signed-off-by: David Matějček <[email protected]>
- LineTokenReplacer now uses just UTF-8
- JVM has no power to find out which charset uses the administrator user,
lets use the standard.
- Uses try-with and enhanced loop now
- Class attributes moved to the top
- Two String paths changed to File, methods renamed
- Deleted unused TokenReplacementTester
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- however parser used default charset and swallowed errors. Signed-off-by: David Matějček <[email protected]>
- Logging can print stacktraces on its own Signed-off-by: David Matějček <[email protected]>
- META-INF/hk2-locator/default is encoded in UTF-8 - close() exceptions not swallowed any more - Removed duplicit isLoggable - try-with - getDeclaredConstructor usage - SimpleInjectionResolver moved to the bottom Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- The behavior was correct, the encoding is related to the input file, but when reading from console, we always use default charset. Signed-off-by: David Matějček <[email protected]>
- Uses UTF-8, not default charset - Fixed unclosed IO warning - symmetric <ul> element - if it breaks, you cannot fix it by closing the element - Reordered methods for better readability - try-with - originally those fields were closed, but were kept after. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
…itten - note: readAllBytes uses 8K buffer which should be sufficient to read all used resource files (status.html). Signed-off-by: David Matějček <[email protected]>
- When printing to stdout with different charset, the byte stream has to be reencoded. - The report has to be encoded in UTF-8 - For XML the application/xml is preferred. - Optimizations Signed-off-by: David Matějček <[email protected]>
…ault - Using Charset.defaultCharset as default can break things when client simply did not set the value in the header. Then we cannot assume too much, however UTF-8 is an industry standard. In some usage it even does not matter as ie. digest numbers can be always encoded to UTF-8 (or even Latin1). - The original Grizzly's getCharsetFromContentType is not reachable for some classloaders and also returned String, so I copy pasted it and changed it a bit for the purpose. Signed-off-by: David Matějček <[email protected]>
- Using UTF-8 instead of default charset - Throwing exception if method failed, don't hide errors. Signed-off-by: David Matějček <[email protected]>
- Always use the same UTF-8 charset to encode/decode master password Signed-off-by: David Matějček <[email protected]>
- Reduced copy-paste - ContentType is not the only header supporting charsets, Authorization too - Parsing response from HTTP connection is quite useful - Resolved hardcoded password - we can generate it for tests - Resolved dependency on default charset Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Using 8K buffers instead of 1K (default JDK readAllBytes, replaced old impl) - Using UTF-8 where possible, RestAdapter now specifies charset in contentType - TextResourcesGenerator now uses Properties to write properties - Small syntax changes Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
dmatej
requested review from
arjantijms,
pzygielo,
hs536,
avpinchuk and
a team
arjantijms
approved these changes
Sep 18, 2024
|
Just spot checked, but lgtm |
hs536
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
I recommend to review each commit,
Just one note before you notice - the commit "Fixed parsing charset from ContentType..." fixes mistake I made in "SpotBugs-based cleanup in security module" where I tried to parse Charset from the whole content type header, not just the charset parameter.
Changes