Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetUtils revisited #25117

Merged
merged 8 commits into from
Aug 27, 2024
Merged

NetUtils revisited #25117

merged 8 commits into from
Aug 27, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Aug 26, 2024

  • See individual commit messages, however review whole diff
  • Deleted, renamed, simplified methods, added or revisited few javadocs
  • Fixed one possible NPE
  • Removed dead code.

dmatej added 8 commits August 26, 2024 12:02
Signed-off-by: David Matějček <[email protected]>
- It doesn't have reason the log it in the original method in unexpected
  situations (I wanted just to check if the port is free)
- However it is an important warning.
- Idea: CLI commands should report detected basic issues which might cause
  problems with CLI command execution. Server instances should do that on
  startup too.

Signed-off-by: David Matějček <[email protected]>
- Unused and commented out code, formatting

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- getFreePort now throws ISE on error
  - originally returned zero
  - the only usage is in DomainPortValidator, however now it can be used on
    other places too.
- Order of methods for better orientation
  - first methods using other methods in the same class
  - first ports, then hosts
- Removed unused methods

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added this to the 7.0.17 milestone Aug 26, 2024
@dmatej dmatej self-assigned this Aug 26, 2024
Copy link
Contributor

@hs536 hs536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmatej dmatej merged commit 9feecec into eclipse-ee4j:master Aug 27, 2024
2 checks passed
@dmatej dmatej deleted the netutils branch August 27, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants