Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): added new motion tokens #2562

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Feb 5, 2025

Fixes #2530

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added new motion tokens with functions
  • Replaced the raw values in accordion with new tokens
  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Feb 5, 2025
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: a7149ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ArtBlue ArtBlue requested a review from HenriqueLimas February 6, 2025 14:43
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but have one comment.
Either way its fine

@ArtBlue ArtBlue merged commit 59d2e12 into 19.1.0 Feb 6, 2025
@ArtBlue ArtBlue deleted the 2530-new-motion-tokens branch February 6, 2025 17:23
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants